On Fri, 26 Nov 2010, Vasiliy Kulikov wrote: > clk_get() returns ERR_PTR() on error, not NULL. > > Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx> Yep, there are, probably, a couple more of these, similar to http://marc.info/?t=128715350900002&r=1&w=2 Hardly required, but if you like: Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> Thanks Guennadi > --- > Cannot compile this driver, so it is not tested at all. > > arch/sh/boards/mach-se/7724/setup.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c > index c31d228..6735305 100644 > --- a/arch/sh/boards/mach-se/7724/setup.c > +++ b/arch/sh/boards/mach-se/7724/setup.c > @@ -871,14 +871,14 @@ static int __init devices_setup(void) > > /* set SPU2 clock to 83.4 MHz */ > clk = clk_get(NULL, "spu_clk"); > - if (clk) { > + if (!IS_ERR(clk)) { > clk_set_rate(clk, clk_round_rate(clk, 83333333)); > clk_put(clk); > } > > /* change parent of FSI A */ > clk = clk_get(NULL, "fsia_clk"); > - if (clk) { > + if (!IS_ERR(clk)) { > clk_register(&fsimcka_clk); > clk_set_parent(clk, &fsimcka_clk); > clk_set_rate(clk, 11000); > -- > 1.7.0.4 > > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
