On Thu, Nov 25, 2010 at 01:28:57AM +0100, Javier Martinez Canillas wrote: > adev->guest_msix_entries = > - kzalloc(sizeof(struct msix_entry) * entry_nr->entry_nr, > + kzalloc(sizeof(struct msix_entry) *entry_nr->entry_nr, The original code was right and the new code is wrong. > GFP_KERNEL); > if (!adev->guest_msix_entries) { > kfree(adev->host_msix_entries); > @@ -750,7 +750,7 @@ long kvm_vm_ioctl_assigned_device(struct kvm *kvm, unsigned ioctl, > goto out_free_irq_routing; > r = kvm_set_irq_routing(kvm, entries, routing.nr, > routing.flags); > - out_free_irq_routing: > +out_free_irq_routing: This is a pointless change. > vfree(entries); > break; You're wasting people's time here and we like newbies but it makes everyone annoyed. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html