On Thu, 18 Nov 2010, Alan Cox wrote: > On Thu, 18 Nov 2010 21:44:21 +0300 > Vasiliy Kulikov <segoon@xxxxxxxxxxxx> wrote: > > > On Thu, Nov 18, 2010 at 18:18 +0000, Alan Cox wrote: > > > > I cannot compile this driver in next-20101117, so it is not > > > > tested at all. > > > > > > Compile or test - if it bombs out compiling for you please send me > > > (off list the .config that fails so I can fix that > > > > > > Otherwise NAK the patch because it needs to do the cleanup but > > > thanks for finding the bug - you've done the hard 99% > > > > make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o > > make: Entering directory `/home/vasya/dev/linux-next' > > CHK include/linux/version.h > > CHK include/generated/utsrelease.h > > CALL scripts/checksyscalls.sh > > CC arch/x86/platform/mrst/vrtc.o > > arch/x86/platform/mrst/vrtc.c: In function 'mrst_rtc_init': > > arch/x86/platform/mrst/vrtc.c:113: error: 'FIX_LNW_VRTC' undeclared > > (first use in this function) arch/x86/platform/mrst/vrtc.c:113: > > error: (Each undeclared identifier is reported only once > > arch/x86/platform/mrst/vrtc.c:113: error: for each function it > > appears in.) make[1]: *** [arch/x86/platform/mrst/vrtc.o] Error 1 > > > > Both with allyesconfig and allmodconfig, x86_64. > > I can't duplicate this. > > It's defined if CONFIG_X86_MRST is defined, and the file in question is > only compiled if CONFIG_X86_MRST is defined Of course you can't duplicate this: > > make -C /home/vasya/linux arch/x86/platform/mrst/vrtc.o Vasiliy forced a manual compile of that file with a 64bit config which has CONFIG_X86_MRST=n. That's PEBKAC not a build failure :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
