On Sun, Nov 14, 2010 at 23:29 +0300, Dan Carpenter wrote: > On Sun, Nov 14, 2010 at 11:08:39PM +0300, Vasiliy Kulikov wrote: > > do_verify_xattr_datum(), do_load_xattr_datum(), load_xattr_datum() > > and verify_xattr_ref() should return negative value on error. > > Sometimes they return EIO that is positive. Change this to -EIO. > > > > Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx> > > --- > > This driver is not compilable, so the patch is not tested. > > > > It compiles. Really? x86_64, linux-next: make -C /home/vasya/linux fs/jffs2/xattr.o make: ÐÑÐÐ Ð ÐÐÑÐÐÐÐ `/home/vasya/dev/linux-next' CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CC fs/jffs2/xattr.o fs/jffs2/xattr.c: In function âunload_xattr_datumâ: fs/jffs2/xattr.c:87: error: âstruct jffs2_sb_infoâ has no member named âxdatum_mem_usageâ fs/jffs2/xattr.c: In function âreclaim_xattr_datumâ: fs/jffs2/xattr.c:105: error: âstruct jffs2_sb_infoâ has no member named âxdatum_mem_thresholdâ fs/jffs2/xattr.c:105: error: âstruct jffs2_sb_infoâ has no member named âxdatum_mem_usageâ fs/jffs2/xattr.c:108: error: âstruct jffs2_sb_infoâ has no member named âxdatum_mem_usageâ fs/jffs2/xattr.c:109: error: âstruct jffs2_sb_infoâ has no member named âxdatum_mem_usageâ fs/jffs2/xattr.c:110: error: âXATTRINDEX_HASHSIZEâ undeclared (first use in this function) fs/jffs2/xattr.c:110: error: (Each undeclared identifier is reported only once fs/jffs2/xattr.c:110: error: for each function it appears in.) For both defconfig and allyesconfig. > regards, > dan carpenter > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Vasiliy -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
