Re: [patch] rtc: jz4740: signedness bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dan Carpenter wrote:
> platform_get_irq() can return negatives so the rtc->irq should be signed
> to handle it.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>

Acked-By: Lars-Peter Clausen <lars@xxxxxxxxxx>

Thanks.
> 
> diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> index 2e16f72..cfcd2da 100644
> --- a/drivers/rtc/rtc-jz4740.c
> +++ b/drivers/rtc/rtc-jz4740.c
> @@ -42,7 +42,7 @@ struct jz4740_rtc {
>  
>  	struct rtc_device *rtc;
>  
> -	unsigned int irq;
> +	int irq;
>  
>  	spinlock_t lock;
>  };

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux