On Fri, Nov 12, 2010 at 07:24:24AM -0600, Larry Finger wrote: > On 11/11/2010 11:11 PM, Dan Carpenter wrote: > > PollingCnt is 20 and that means we loop 20 times and then run the > > timeout code. After the end of the loop PollingCnt should be -1 but > > because it's an unsigned char, it's actually 255 and the timeout > > code never runs. > > > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > > As a point of interest, did you actually hit a timeout, or was this found by a > code audit? This was a static check thing. (http://smatch.sf.net) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
