On Sat, Nov 06, 2010 at 05:41:31PM +0300, Vasiliy Kulikov wrote: > Structure iowarrior_info is copied to userland with padding byted > between "serial" and "revision" fields uninitialized. It leads to > leaking of contents of kernel stack memory. > > Signed-off-by: Vasiliy Kulikov <segooon@xxxxxxxxx> Acked-by: Kees Cook <kees.cook@xxxxxxxxxxxxx> > --- > Compile tested. > > drivers/usb/misc/iowarrior.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c > index 3756641..c9078e4 100644 > --- a/drivers/usb/misc/iowarrior.c > +++ b/drivers/usb/misc/iowarrior.c > @@ -553,6 +553,7 @@ static long iowarrior_ioctl(struct file *file, unsigned int cmd, > /* needed for power consumption */ > struct usb_config_descriptor *cfg_descriptor = &dev->udev->actconfig->desc; > > + memset(&info, 0, sizeof(info)); > /* directly from the descriptor */ > info.vendor = le16_to_cpu(dev->udev->descriptor.idVendor); > info.product = dev->product_id; > -- > 1.7.0.4 -- Kees Cook Ubuntu Security Team -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
