Hi Dan, Thanks for your reply, the truth is the original message was sent with "git send-mail" while on the other hand I fwd'ed this to the janitors ML with the Gmail webclient, that's probably what mangled it. So I'm guessing the former was sent correctly? I did Cc Ben Collins and he replied with an "Acked-By:". Sincerely, Facundo On Sat, Nov 6, 2010 at 1:05 AM, Dan Carpenter <error27@xxxxxxxxx> wrote: > On Fri, Nov 05, 2010 at 08:08:35PM -0300, Facundo Gaich wrote: >> (Forgot to Cc this list in the original email. By the way, I sent this >> to greg@kroah instead of greg@suse, because that's what the TODO file >> said. I hope that's still ok?) >> >> This patch fixes all errors and most warnings reported by >> checkpatch.pl for all the files in the driver. > > Hi Facundo, > > Your email client is mangling this patch. It's wrapping the lines and > changing the spaces to tabs. > > Please read Documentation/email-clients.txt. Then send an email to > yourself and verify that the patch applies. (Save it as a raw email. > cat raw_email.txt | patch -p1 -R). Then resend and we can review it. > > I didn't see the original email, but don't forget to CC Ben Collins as > well. His email is <bcollins@xxxxxxxxxxxxxx>. And CC the staging list > too <devel@xxxxxxxxxxxxxxxxxxxx>. > > regards, > dan carpenter > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
