On Wed, Oct 27, 2010 at 04:50:31PM +0200, Dan Carpenter wrote:
> If "p" is NULL then it will cause an oops when we pass it to
> simple_strtoul(). In this case "p" can not be NULL so I removed the
> check. I also changed the check a little to make it more explicit that
> we are testing whether p points to the NUL char.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Acked-by: Joel Becker <joel.becker@xxxxxxxxxx>
> ---
> V2: Added some parenthesis to make the precedence more clear.
>
> diff --git a/Documentation/filesystems/configfs/configfs_example_explicit.c b/Documentation/filesystems/configfs/configfs_example_explicit.c
> index d428cc9..63ff248 100644
> --- a/Documentation/filesystems/configfs/configfs_example_explicit.c
> +++ b/Documentation/filesystems/configfs/configfs_example_explicit.c
> @@ -89,7 +89,7 @@ static ssize_t childless_storeme_write(struct childless *childless,
> char *p = (char *) page;
>
> tmp = simple_strtoul(p, &p, 10);
> - if (!p || (*p && (*p != '\n')))
> + if ((*p != '\0') && (*p != '\n'))
> return -EINVAL;
>
> if (tmp > INT_MAX)
>
--
"Sometimes I think the surest sign intelligent
life exists elsewhere in the universe is that
none of it has tried to contact us."
-Calvin & Hobbes
Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker@xxxxxxxxxx
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
