On Wed, Oct 27, 2010 at 05:50:25PM -0400, J. Bruce Fields wrote: > On Wed, Oct 27, 2010 at 11:19:04PM +0200, Dan Carpenter wrote: > > The original code would oops if this were called from nfsd4_setattr() > > because "filpp" is NULL. > > I believe it's impossible to reach this case: we never give out write > delegations, so the preceding nfs4_check_delegmode will always fail when > called from setattr. > > We should do this anyway, but I'll probably queue it up for the next > merge window. Sounds good. This was a static checker patch not a run time bug (as you obviously realized). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
