On Tue, Oct 26, 2010 at 11:09:08PM -0200, Henrique de Moraes Holschuh wrote: > On Tue, 26 Oct 2010, Julia Lawall wrote: > > From: Julia Lawall <julia@xxxxxxx> > > > > Delete successive assignments to the same location. > > There are often results of mismerges or other assorted screw ups, often > done by the maintainer itself (e.g. me in thinkpad-acpi's case) during > development. > > The patch is correct, and I thank you for the head's up. But let me > track down what caused it first, hmm? I also highly recommend that this > should be done in all cases you find, instead of just blindly fixing the > assignment. I've reviewed the entire patchset per your suggestion and Julia obviously didn't do it blindly. It all looks good. The patcheset fixes a number of bugs. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html