On 22:51 Sun 03 Oct , Sam Ravnborg wrote: > On Sun, Oct 03, 2010 at 02:40:01PM +0200, walter harms wrote: > > > > > > Tracey Dent schrieb: > > > Changed to use the proper ccflags-y option > > > > > > Signed-off-by: Tracey Dent <tdent48227@xxxxxxxxx> > > > --- > > > drivers/staging/cx25821/Makefile | 8 ++++---- > > > 1 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/staging/cx25821/Makefile b/drivers/staging/cx25821/Makefile > > > index d0eb16e..6448364 100644 > > > --- a/drivers/staging/cx25821/Makefile > > > +++ b/drivers/staging/cx25821/Makefile > > > @@ -7,7 +7,7 @@ cx25821-objs := cx25821-core.o cx25821-cards.o cx25821-i2c.o \ > > > obj-$(CONFIG_VIDEO_CX25821) += cx25821.o > > > obj-$(CONFIG_VIDEO_CX25821_ALSA) += cx25821-alsa.o > > > > > > -EXTRA_CFLAGS += -Idrivers/media/video > > > -EXTRA_CFLAGS += -Idrivers/media/common/tuners > > > -EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core > > > -EXTRA_CFLAGS += -Idrivers/media/dvb/frontends > > > +ccflags-y := -Idrivers/media/video > > > +ccflags-y += -Idrivers/media/common/tuners > > > +ccflags-y += -Idrivers/media/dvb/dvb-core > > > +ccflags-y += -Idrivers/media/dvb/frontends > > > > they have invented vpath for this, did they ? > > note: I am not familiar with the linux makefile. > vpath is not the answer here. > > Note that Tracy dent did the simple replacement of EXTRA_CFLAGS with ccflags-y. > The Makefiles could in many cases benefit from general cleanups - which many > of your futher comments is a good indicator of. Hi Sam, I happen to have sent out a RFC patch for media/ a little over a week ago. Mauro Chehab has not commented on it yet, but I am curious to hear your opinion. http://marc.info/?l=linux-kernel&m=128553496013767&w=2 Thanks, mfm -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
