On Sat, 2 Oct 2010, walter harms wrote: > > > Julia Lawall schrieb: > > This code does not call deinit_card(card); in an error case, as done in > > other error-handling code in the same function. But actually, the called > > function init_sram can only return 0, so there is no need for the error > > check at all. > > > > > did you set init_sram() to void ? No, that indeed seems like a reasonable change. Patch shortly. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html