On Sat, Sep 25, 2010 at 12:52:44PM +0200, walter harms wrote: > > > Tracey Dent schrieb: > > Changed to use proper ccflags-y option > > > > Signed-off-by: Tracey Dent <tdent48227@xxxxxxxxx> > > --- > > drivers/staging/rtl8192u/Makefile | 20 ++++++++++---------- > > 1 files changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/staging/rtl8192u/Makefile b/drivers/staging/rtl8192u/Makefile > > index 738f4a8..1710921 100644 > > --- a/drivers/staging/rtl8192u/Makefile > > +++ b/drivers/staging/rtl8192u/Makefile > > @@ -1,16 +1,16 @@ > > NIC_SELECT = RTL8192U > > > > -EXTRA_CFLAGS += -std=gnu89 > > -EXTRA_CFLAGS += -O2 > > +ccflags-y := -std=gnu89 > > +ccflags-y := -O2 > > > > Is this -O2 a requirement ? I did not look into other makefiles but i would expect > -O2 to be set in the main-makefile. (Imagine someone disables the optimsation only > to find a driver that does behave different). Yes, it should be removed, but that's not the goal of this patch. > > -EXTRA_CFLAGS += -DCONFIG_FORCE_HARD_FLOAT=y > > -EXTRA_CFLAGS += -DJACKSON_NEW_8187 -DJACKSON_NEW_RX > > -EXTRA_CFLAGS += -DTHOMAS_BEACON -DTHOMAS_TASKLET -DTHOMAS_SKB -DTHOMAS_TURBO > > Is THOMAS_BEACON etc a defined algorithem or so ? If not a bit more desciptive name > would be nice Lots of things would be "nice" for this driver :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
