On 11:04 Mon 27 Sep , Valdis.Kletnieks@xxxxxx wrote: > On Fri, 24 Sep 2010 12:17:14 PDT, matt mooney said: > > Replace EXTRA_CFLAGS with ccflags-y. > > > > Signed-off-by: matt mooney <mfm@xxxxxxxxxxxxx> > > --- > > drivers/hwmon/Makefile | 4 +--- > > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > > index e3c2484..764b4db 100644 > > --- a/drivers/hwmon/Makefile > > +++ b/drivers/hwmon/Makefile > > @@ -109,7 +109,5 @@ obj-$(CONFIG_SENSORS_W83L786NG) += w83l786ng.o > > obj-$(CONFIG_SENSORS_WM831X) += wm831x-hwmon.o > > obj-$(CONFIG_SENSORS_WM8350) += wm8350-hwmon.o > > > > -ifeq ($(CONFIG_HWMON_DEBUG_CHIP),y) > > -EXTRA_CFLAGS += -DDEBUG > > -endif > > +ccflags-$(CONFIG_HWMON_DEBUG_CHIP) := -DDEBUG > > Was this series intended as := rather than += as it seems that > overriding the entirely of a passed-in ccflags-y may not be what > we wanted to do. That is exactly why I changed += to :=. ccflags-y (and the older EXTRA_CFLAGS) is a per directory variable that only has effect on the current directory, so there is no passing in of ccflags-y. -mfm -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
