On Sun, Sep 26, 2010 at 07:11:12PM -0700, matt mooney wrote: >When O= is used, any -I flag given that is not an absolute path gets >duplicated. The $(1) appended to the conditional clause covers the >absolute case, but due to being outside of the conditional statement >it gets added everytime. > >Signed-off-by: matt mooney <mfm@xxxxxxxxxxxxx> Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> >--- > scripts/Kbuild.include | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include >index ed2773e..08c74ed 100644 >--- a/scripts/Kbuild.include >+++ b/scripts/Kbuild.include >@@ -158,7 +158,7 @@ modbuiltin := -f $(if $(KBUILD_SRC),$(srctree)/)scripts/Makefile.modbuiltin obj > # Prefix -I with $(srctree) if it is not an absolute path. > # skip if -I has no parameter > addtree = $(if $(patsubst -I%,%,$(1)), \ >-$(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1)) >+$(if $(filter-out -I/%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1))) > > # Find all -I options and call addtree > flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o))) The original code also missed a comma, this patch fixes it. Thanks! -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
