Re: Fw: [PATCH] drivers/block/cciss.c (2.6.34.7): Fixed useless compile warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 21, 2010 at 02:48:12AM -0700, Poyo VL wrote:
> GCC version: gcc version 4.5.0 20100604 [gcc-4_5-branch revision 160292] (SUSE 
> Linux) 
> 
> And I'm sorry, the kernel version is 2.6.34.7 not 2.6.35.7.

It also applies to the 2.6.36-rc4 kernel with offset 45 so that's ok.

> But I selected almost all options from "make menuconfig", I think this is 
> important to mention.

You can leave this information out.

> All warnings are like this one
> drivers/block/cciss.c: In function âdev_show_unique_idâ:
> drivers/block/cciss.c:564:7: warning: âsn[0]â may be used uninitialized in this 
> function
> I tried to explain. The sn[] array is initialized here: else memcpy(sn, 
> drv->serial_no, sizeof(sn)); so it is initialized in a conditional expression, 
> and is is used downer. So, the compiler think that it can be used unititialized 
> and it throws that warning.

> I fixed the patch, I am sorry, I'm a newbie.

Don't appologize.  Kernel-janitors is here to help newbies.

This version was much better, but your email client is still changing
all the spaces to tabs.  Can you send it again as version 3?  Please
send the email to yourself and verify that the patch applies.  Just save
the email as "raw format with headers" or whatever it's called.  Then
`cat raw_email.txt | patch -p1` and send it to us again once that works.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux