On Fri, Sep 10, 2010 at 01:57:14PM +0200, Dan Carpenter wrote:
> It doesn't make sense to check "!ai->config.rates" here.
> "ai->config.rates" is the address of an eight bytes array and it
> can't ever be null here. Also if it were NULL then trying to set:
> ai->config.rates[i] = basic_rate | 0x80;
> would cause an oops.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
> index 1d05445..d806497 100644
> --- a/drivers/net/wireless/airo.c
> +++ b/drivers/net/wireless/airo.c
> @@ -3886,8 +3886,7 @@ static u16 setup_card(struct airo_info *ai, u8 *mac, int lock)
> }
> if ( basic_rate > 0 ) {
> for( i = 0; i < 8; i++ ) {
> - if ( ai->config.rates[i] == basic_rate ||
> - !ai->config.rates ) {
> + if (ai->config.rates[i] == basic_rate) {
> ai->config.rates[i] = basic_rate | 0x80;
> break;
> }
I think code author wonted to do "!ai->config.rates[i], what mean "if
rate is invalid use basic rate".
I'm not sure if basic_rate module parameter is used by anyone. It's not
described, seems it was created for development purpose. I think we can
remove it ...
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
