On Tue, 31 Aug 2010, Wolfram Sang wrote: > On Tue, Aug 31, 2010 at 05:48:57PM +0200, Julia Lawall wrote: > > Add a call to of_node_put in the error handling code following a call to > > of_find_matching_node. > > > > This patch also moves the existing call to of_node_put after the call to > > iounmap in the error handling code, to make it possible to jump to > > of_node_put without doing iounmap. These appear to be disjoint operations, > > so the ordering doesn't matter. > > Hmm, the function you change returns -ENODEV if a clock cannot be found, but > the return type is u32. This should better be 0. Can you take care of this as > well? I'll look at it. I was trying to make the returned value be signed, which seemed to have some slightly complicated repercussions, but a return value of 0 may work out much better. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
