--- On Sat, 8/28/10, Julia Lawall <julia@xxxxxxx> wrote: > From: Julia Lawall <julia@xxxxxxx> > Subject: Re: [PATCH 2/7] drivers/usb/gadget: Remove double test > To: "Stefan Richter" <stefanr@xxxxxxxxxxxxxxxxx> > Cc: "David Brownell" <david-b@xxxxxxxxxxx>, "Thomas Dahlmann" <dahlmann.thomas@xxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, "David Brownell" <dbrownell@xxxxxxxxxxxxxxxxxxxxx>, "Greg Kroah-Hartman" <gregkh@xxxxxxx>, linux-geode@xxxxxxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx > Date: Saturday, August 28, 2010, 10:17 AM > On Sat, 28 Aug 2010, Stefan Richter > wrote: > > > Julia Lawall wrote: > > > On Sat, 28 Aug 2010, David Brownell wrote: > > > > > >> Please update $SUBJECT to say which driver > is > > >> affected; > > > > > > Done. Thanks. Unless the author/maintainer of this driver objects, the patch is OK by me. > > > > > >> it's not everything in that directory, > > >> and accurate GIT summaries help a lot. > > > > > > Is there some sort of rule that can be > followed? Don't be misleading ... Generally, if it updates just one driver, mention that driver in $SUBJECT. Only say the subsystem itself is being updated (which your original $SUBJECT did) when the patch affects framework code, that's shared by all drivers, > > > What if the > > > patch affects only two files? Which two files? The "patch updates one thing" rule will then cause it to affect only one driver (usually) or some framework issue, so the above policies kick in directly. Rarely there will be bugs repeated (e.g. via cut/paste) in multiple drivers, ... in which case it can make sense to summarize a patch as a multi-driver subsystem fix . Similarly with API changes. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
