Re: [PATCH 2/7] drivers/usb/gadget: Remove double test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 28 Aug 2010, Dan Carpenter wrote:

> On Sat, Aug 28, 2010 at 05:41:01PM +0200, Julia Lawall wrote:
> > This is a guess as to what the code should be.  Perhaps something else
> > should have been tested instead.
> > 
> >  drivers/usb/gadget/amd5536udc.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> > index 731150d..6c40c99 100644
> > --- a/drivers/usb/gadget/amd5536udc.c
> > +++ b/drivers/usb/gadget/amd5536udc.c
> > @@ -203,7 +203,7 @@ static void print_regs(struct udc *dev)
> >  		DBG(dev, "DMA mode       = PPBNDU (packet per buffer "
> >  			"WITHOUT desc. update)\n");
> >  		dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
> > -	} else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
> > +	} else if (use_dma && use_dma_ppb_du) {
> 
> 
> My guess is that "use_dma_ppb" was intended.

Thanks.  I made this change.

julia
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux