Applied, thanks!
sage
On Thu, 26 Aug 2010, Dan Carpenter wrote:
> ceph_mdsc_build_path() returns an ERR_PTR but this code is set up to
> handle NULL returns.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 360c4f2..6fd8b20 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -171,6 +171,8 @@ static int mdsc_show(struct seq_file *s, void *p)
> } else if (req->r_dentry) {
> path = ceph_mdsc_build_path(req->r_dentry, &pathlen,
> &pathbase, 0);
> + if (IS_ERR(path))
> + path = NULL;
> spin_lock(&req->r_dentry->d_lock);
> seq_printf(s, " #%llx/%.*s (%s)",
> ceph_ino(req->r_dentry->d_parent->d_inode),
> @@ -187,6 +189,8 @@ static int mdsc_show(struct seq_file *s, void *p)
> if (req->r_old_dentry) {
> path = ceph_mdsc_build_path(req->r_old_dentry, &pathlen,
> &pathbase, 0);
> + if (IS_ERR(path))
> + path = NULL;
> spin_lock(&req->r_old_dentry->d_lock);
> seq_printf(s, " #%llx/%.*s (%s)",
> ceph_ino(req->r_old_dentry->d_parent->d_inode),
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
