On Tue, Aug 24, 2010 at 5:15 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > On Tue, 2010-08-24 at 14:07 +0200, Dan Carpenter wrote: >> The indenting is not correct here. I don't have this hardware and I'm >> just guessing as to what was intended. I think that if there is an >> error we should return an error code, but if there isn't an error we >> should return success directly without releasing the firmware. > [...] > > The driver doesn't use or refer to the firmware image once it's copied > into device RAM, so this just leaks the firmware. > > The driver *should* keep a reference so it can restore the firmware > after suspend/resume without filesystem access (which is likely to > deadlock). Well, if all you want to do is put the device into "deep sleep" mode, you will not need a firmware reload after waking it up. P.S. I notice that if_spi.c is still setting priv->enter_deep_sleep = NULL Too bad. This feature IS available with the SPI interface. regards, Colin McCabe -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
