On 2010-08-18 at 10:27:53 +0200, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote: > Le mercredi 18 août 2010 à 09:13 +0100, Russell King - ARM Linux a > écrit : > > On Wed, Aug 18, 2010 at 09:04:24AM +0200, Tobias Klauser wrote: > > > @@ -965,7 +965,7 @@ ether1_close (struct net_device *dev) > > > static struct net_device_stats * > > > ether1_getstats (struct net_device *dev) > > > { > > > - return &priv(dev)->stats; > > > + return &dev->stats; > > > } > > > > Doesn't the core do this for you already if you omit this function? > > > > Same comment for ether3.c > > Yes, thats right, no need to declare ndo_get_stats() methods that only > returns &dev->stats Thanks. I'll send another updated patch, omitting the ether1_getstats (same for ether3). Sorry for the mess. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html