On Mon, 2010-08-16 at 18:27 +0200, ext Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Error codes are stored in ret, but the return value is always 0. Return > ret instead. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r@ > local idexpression x; > constant C; > @@ > > if (...) { ... > x = -C > ... when != x > ( > return <+...x...+>; > | > return NULL; > | > return; > | > * return ...; > ) > } > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- This was indeed a bug. Thanks! Acked-by: Luciano Coelho <luciano.coelho@xxxxxxxxx> -- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
