On Mon, Aug 16, 2010 at 06:26:57PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > Error codes are stored in err, but the return value is always 0. Return > err instead. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @r@ > local idexpression x; > constant C; > @@ > > if (...) { ... > x = -C > ... when != x > ( > return <+...x...+>; > | > return NULL; > | > return; > | > * return ...; > ) > } > // </smpl> > > Signed-off-by: Julia Lawall <julia@xxxxxxx> > > --- > This changes the semantics and has not been tested. It restores the semantics to what they should be and used to be. This probably happened during the introduction of proper refcounting and locking into the AX.25 stack. Looks fine to me. Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Ralf -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
