From: Julia Lawall <julia@xxxxxxx> An error code is stored in the variable error, but it is the variable result that is returned instead. So store the error code in result. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> --- This changes the semantics and has not been tested. In each case, error is also assigned to the result of a function call. Perhpas that should be changed to result as well, and error should be eliminated. drivers/platform/x86/fujitsu-laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index f44cd26..e7d2259 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -668,7 +668,7 @@ static int acpi_fujitsu_add(struct acpi_device *device) fujitsu->input = input = input_allocate_device(); if (!input) { - error = -ENOMEM; + result = -ENOMEM; goto err_stop; } @@ -833,7 +833,7 @@ static int acpi_fujitsu_hotkey_add(struct acpi_device *device) fujitsu_hotkey->input = input = input_allocate_device(); if (!input) { - error = -ENOMEM; + result = -ENOMEM; goto err_free_fifo; } -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
