From: Julia Lawall <julia@xxxxxxx> Error codes are stored in retval, but the return value is always 0. Return retval in the error case instead. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by: Julia Lawall <julia@xxxxxxx> --- This changes the semantics of the code and has not been tested. Furthermore, there is another call, to fwnet_pd_update, where there is a goto to bad_proto (the label associated with the second block of code), and that does not set retval. Perhaps a value should be chosen in that case. Or perhaps retval should just be dropped, if it is not going to be used. drivers/firewire/net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index da17d40..8d91484 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -681,7 +681,7 @@ static int fwnet_incoming_packet(struct fwnet_device *dev, __be32 *buf, int len, int fg_off; int dg_size; u16 datagram_label; - int retval; + int retval = 0; u16 ether_type; hdr.w0 = be32_to_cpu(buf[0]); @@ -801,7 +801,7 @@ static int fwnet_incoming_packet(struct fwnet_device *dev, __be32 *buf, int len, if (netif_queue_stopped(net)) netif_wake_queue(net); - return 0; + return retval; } static void fwnet_receive_packet(struct fw_card *card, struct fw_request *r, -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
