Dan Carpenter wrote: > There is no need to check "s". nla_data() doesn't return NULL. Also we > already dereferenced "s" at this point so it would have oopsed ealier if > it were NULL. Looks OK to me. Jarek P. > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index 408eea7..6fb3d41 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -360,7 +360,7 @@ static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt) > tsize = nla_len(tb[TCA_STAB_DATA]) / sizeof(u16); > } > > - if (!s || tsize != s->tsize || (!tab && tsize > 0)) > + if (tsize != s->tsize || (!tab && tsize > 0)) > return ERR_PTR(-EINVAL); > > spin_lock(&qdisc_stab_lock); > -- -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
