From: Joe Perches <joe@xxxxxxxxxxx> Date: Mon, 09 Aug 2010 20:39:06 -0700 > On Mon, 2010-08-09 at 20:31 -0700, Anirban Chakraborty wrote: >> On Aug 10, 2010, at 7:33 AM, Joe Perches wrote: >> > On Mon, 2010-08-09 at 18:43 -0700, Anirban Chakraborty wrote: >> >> Your patch is fine except that the preferred way is to use kzalloc over kaclloc. kzalloc does not need that extra >> >> argument that you are passing to kcalloc. >> > You probably meant to write "my preferred way" >> > as the kcalloc to "kzalloc with a multiply" >> > ratio is pretty high. >> I was suggesting based on the following: >> http://lwn.net/Articles/147014/ > > Note that article suggests kzalloc for allocating > a single zeroed object. > > kcalloc is used for multiple zeroed objects and > protects against oversized allocations. Agreed, kcalloc should be used here. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
