On Aug 10, 2010, at 12:12 AM, Dan Carpenter wrote: > On Mon, Aug 09, 2010 at 09:46:32AM -0700, Anirban Chakraborty wrote: >> >> It looks fine except that I'd use kzalloc instead of kcalloc above. >> > > It's no problem to do that, and I'm already respinning the patches but > I'm confused. It looks like pci_info gets initialized correctly. What > am I missing? Your patch is fine except that the preferred way is to use kzalloc over kaclloc. kzalloc does not need that extra argument that you are passing to kcalloc. -Anirban-- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
