From: Kulikov Vasiliy <segooon@xxxxxxxxx> Date: Fri, 6 Aug 2010 23:51:41 +0400 > Driver should call disable_pci_device() if it returns from pci_probe() "pci_disable_device()" > with error. Also it must not be called if request_region() fails as > it means that somebody uses device resources and rules the device. This interface, frankly, sucks. If this is what we want then pci_enable_device() and pci_disable_device() should maintain a reference count, so that device drivers need not be mindful of what arbitrary special circumstances they should make the disable call or not. They can make it unconditionally and the PCI layer makes sure the device doesn't get disabled unintentionally. This is software interface design 101. The current requirements are beyond unreasonable and should be fixed before we apply patches like this. I'm tossing all of these patches, sorry. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
