If we have a ns name without a following profile then in the original
code it did "*ns_name = &name[1];". "name" is NULL so "*ns_name" is
0x1. That isn't useful and could cause an oops when this function is
called from aa_remove_profiles().
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
---
I'm not very familiar with this code and I haven't tested my fix.
Sorry. Please review carefully.
diff --git a/security/apparmor/lib.c b/security/apparmor/lib.c
index 6e85cdb..da34011 100644
--- a/security/apparmor/lib.c
+++ b/security/apparmor/lib.c
@@ -44,10 +44,12 @@ char *aa_split_fqname(char *fqname, char **ns_name)
/* overwrite ':' with \0 */
*split = 0;
name = skip_spaces(split + 1);
- } else
+ *ns_name = &name[1];
+ } else {
/* a ns name without a following profile is allowed */
+ *ns_name = &name[1];
name = NULL;
- *ns_name = &name[1];
+ }
}
if (name && *name == 0)
name = NULL;
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
