Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device. Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> --- drivers/char/sx.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/char/sx.c b/drivers/char/sx.c index 5b24db4..5140b0d 100644 --- a/drivers/char/sx.c +++ b/drivers/char/sx.c @@ -2711,6 +2711,7 @@ err_unmap: iounmap(board->base2); err_reg: pci_release_region(pdev, reg); + pci_disable_device(pdev); err_flag: board->flags &= ~SX_BOARD_PRESENT; err: -- 1.7.0.4 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
