On Fri, 6 Aug 2010, Bruno Prémont wrote:
> Thanks for spotting!
>
> But while fixing this one also fix the ordering (which was never
> reached due to this wrong check) a few lines later.
>
> Patch (combined) at the end.
>
> Thanks,
> Bruno
>
>
> On Fri, 6 Aug 2010 08:28:49 Dan Carpenter <error27@xxxxxxxxx> wrote:
> > "ref_cnt" is a point to the reference count and it's non-null. We really
> > want to test the reference count itself.
> >
> > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> >
> > diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
> > index 346f0e3..c0bdeba 100644
> > --- a/drivers/hid/hid-picolcd.c
> > +++ b/drivers/hid/hid-picolcd.c
> > @@ -547,7 +547,7 @@ static void picolcd_fb_destroy(struct fb_info *info)
> > ref_cnt--;
> > mutex_lock(&info->lock);
> > (*ref_cnt)--;
> > - may_release = !ref_cnt;
> > + may_release = !*ref_cnt;
> > mutex_unlock(&info->lock);
> > if (may_release) {
> > framebuffer_release(info);
>
> --- a/drivers/hid/hid-picolcd.c
> +++ b/drivers/hid/hid-picolcd.c
> @@ -547,11 +547,11 @@ static void picolcd_fb_destroy(struct fb
> ref_cnt--;
> mutex_lock(&info->lock);
> (*ref_cnt)--;
> - may_release = !ref_cnt;
> + may_release = !*ref_cnt;
> mutex_unlock(&info->lock);
> if (may_release) {
> - framebuffer_release(info);
> vfree((u8 *)info->fix.smem_start);
> + framebuffer_release(info);
> }
> }
I have applied the patch fixing the ordering, along with adding
Signed-off-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx>
to it. Please shoud if that is not proper.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
