Re: [PATCH] kprobes: add sparse context annotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ananth N Mavinakayanahalli wrote:
> On Fri, Aug 06, 2010 at 05:12:55PM +0900, Namhyung Kim wrote:
> 
>>  void __kprobes kretprobe_hash_unlock(struct task_struct *tsk,
>>  	unsigned long *flags)
>> +__releases(hlisk_lock)
> 
> You surely meant hlist_lock, didn't you?
> 
>>  {
>>  	unsigned long hash = hash_ptr(tsk, KPROBE_HASH_BITS);
>>  	spinlock_t *hlist_lock;
>> @@ -859,6 +862,7 @@ void __kprobes kretprobe_hash_unlock(struct task_struct *tsk,
>>
>>  static void __kprobes kretprobe_table_unlock(unsigned long hash,
>>         unsigned long *flags)
>> +__releases(hlisk_lock)
> 		^^^^^^
>>  {
>>  	spinlock_t *hlist_lock = kretprobe_table_lock_ptr(hash);
>>  	spin_unlock_irqrestore(hlist_lock, *flags);
>> -- 
>> 1.7.0.4

Oops, right...

-- 
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux