On Tue, 3 Aug 2010 19:44:16 +0400 Kulikov Vasiliy <segooon@xxxxxxxxx> wrote: > IRQ and resource[] may not have correct values until > after PCI hotplug setup occurs at pci_enable_device() time. > > The semantic match that finds this problem is as follows: > > // <smpl> > @@ > identifier x; > identifier request ~= "pci_request.*|pci_resource.*"; > @@ > > ( > * x->irq > | > * x->resource > | > * request(x, ...) > ) > ... > *pci_enable_device(x) > // </smpl> > > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> > --- > drivers/platform/x86/intel_ips.c | 11 ++++++----- > 1 files changed, 6 insertions(+), 5 deletions(-) Yep, thanks. Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> -- Jesse Barnes, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html