On Tue, Aug 03, 2010 at 03:10:22AM +0200, Christoph Fritz wrote: > If kzalloc() fails return with -ENOMEM from ipw2100_net_init() which is > called by register_netdev. > > Signed-off-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx> > --- > drivers/net/wireless/ipw2x00/ipw2100.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c > index 0bd4dfa..908c176 100644 > --- a/drivers/net/wireless/ipw2x00/ipw2100.c > +++ b/drivers/net/wireless/ipw2x00/ipw2100.c > @@ -1924,6 +1924,8 @@ static int ipw2100_net_init(struct net_device *dev) > bg_band->channels = > kzalloc(geo->bg_channels * > sizeof(struct ieee80211_channel), GFP_KERNEL); > + if (!bg_band->channels) There should be an "ipw2100_down(priv);" on the error path here. > + return -ENOMEM; > /* translate geo->bg to bg_band.channels */ regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
