Please, remove my address praxis@xxxxxxxxxxxx from your lists! I am receiving unwanted mail from a lot of people around kernel, ubuntu' debian, etc - and I have no idea why! Thank you. -----Original Message----- From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-owner@xxxxxxxxxxxxxxx] On Behalf Of Sergei Shtylyov Sent: Sunday, August 01, 2010 1:07 PM To: Kulikov Vasiliy Cc: kernel-janitors@xxxxxxxxxxxxxxx; David Brownell; Greg Kroah-Hartman; Tony Lindgren; Cory Maccarrone; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH 5/7] usb: omap_udc: check return value of proc_create() Hello. Kulikov Vasiliy wrote: > proc_create() may fail, if so return -ENOMEM. > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> [...] > diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c > index f81e4f0..1083216 100644 > --- a/drivers/usb/gadget/omap_udc.c > +++ b/drivers/usb/gadget/omap_udc.c > @@ -2544,9 +2544,9 @@ static const struct file_operations proc_ops = { > .release = single_release, > }; > > -static void create_proc_file(void) > +static int create_proc_file(void) > { > - proc_create(proc_filename, 0, NULL, &proc_ops); > + return (proc_create(proc_filename, 0, NULL, &proc_ops) == NULL); Parens not needed around the *return* expression. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ __________ Information from ESET NOD32 Antivirus, version of virus signature database 5329 (20100731) __________ The message was checked by ESET NOD32 Antivirus. http://www.eset.com __________ Information from ESET NOD32 Antivirus, version of virus signature database 5329 (20100731) __________ The message was checked by ESET NOD32 Antivirus. http://www.eset.com -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
