On Fri, Jul 30, 2010 at 03:08:00PM +0400, Kulikov Vasiliy wrote: > if (size > 0) { > buf = kmalloc(size, GFP_KERNEL); > + if (buf == NULL) { > + pr_err("zfwUsbSubmitControl() failed, " > + "kmalloc() returned NULL\n"); This isn't a big deal, but the pr_err() isn't needed. kmalloc() already prints a message unless __GFP_NOWARN is used. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html