Kulikov Vasiliy schrieb: > kmalloc() may fail, if so return error from zfwUsbSubmitControl(). > > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> > --- > drivers/staging/otus/wrap_usb.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/otus/wrap_usb.c b/drivers/staging/otus/wrap_usb.c > index 93459ca..9f04047 100644 > --- a/drivers/staging/otus/wrap_usb.c > +++ b/drivers/staging/otus/wrap_usb.c > @@ -104,6 +104,11 @@ u32_t zfwUsbSubmitControl(zdev_t *dev, u8_t req, u16_t value, u16_t index, > > if (size > 0) { > buf = kmalloc(size, GFP_KERNEL); > + if (buf == NULL) { > + pr_err("zfwUsbSubmitControl() failed, " > + "kmalloc() returned NULL\n"); > + return 1; > + } > memcpy(buf, (u8_t *)data, size); > } else > buf = NULL; We had a memdup() somewhere had'nt we ? re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html