On 07/23/2010 06:34 PM, Kulikov Vasiliy wrote:
> mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
> NULL check is performed in mxser_interrupt() so it is redundant here.
>
> Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>
Acked-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> ---
> drivers/char/mxser.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index d2692d4..3fc89da 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
> port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
> port->icount.tx += (cnt - port->xmit_cnt);
>
> - if (port->xmit_cnt < WAKEUP_CHARS && tty)
> + if (port->xmit_cnt < WAKEUP_CHARS)
> tty_wakeup(tty);
>
> if (port->xmit_cnt <= 0) {
--
js
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
