From: "Rose, Gregory V" <gregory.v.rose@xxxxxxxxx> Date: Thu, 15 Jul 2010 11:52:54 -0700 >>-----Original Message----- >>From: Kulikov Vasiliy [mailto:segooon@xxxxxxxxx] >>Sent: Thursday, July 15, 2010 11:46 AM >>To: kernel-janitors@xxxxxxxxxxxxxxx >>Cc: David S. Miller; Kirsher, Jeffrey T; Rose, Gregory V; Eric Dumazet; >>Joe Perches; netdev@xxxxxxxxxxxxxxx >>Subject: [PATCH 5/8] drivers: ixgbevf: fix unsigned underflow >> >>'count' is unsigned. It is initialized to zero, then it can be increased >>multiple times, and finally it is used in such a way: >> >> >>>> count--; >> | >> | /* clear timestamp and dma mappings for remaining portion of >>packet */ >> | while (count >= 0) { >> | count--; >> | ... >> ^ >>If count is zero here (so, it was never increased), we would have a very >>long loop :) >> >>Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> ... > Acked By: Greg Rose <gregory.v.rose@xxxxxxxxx> Applied. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
