On Thu, Jul 15, 2010 at 10:39:47AM +0200, Dan Carpenter wrote:
> If the kzalloc() fails we should return NULL. All the places that call
> alloc_apertures() check for this already.
Thanks for fixing this. I added this function, so FWIW:
Acked-by: Marcin Slusarz <marcin.slusarz@xxxxxxxxx>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 8e5a9df..e7445df 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -873,6 +873,8 @@ struct fb_info {
> static inline struct apertures_struct *alloc_apertures(unsigned int max_num) {
> struct apertures_struct *a = kzalloc(sizeof(struct apertures_struct)
> + max_num * sizeof(struct aperture), GFP_KERNEL);
> + if (!a)
> + return NULL;
> a->count = max_num;
> return a;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
