On Sat, 10 Jul 2010 14:03:18 +0400, Kulikov Vasiliy <segooon@xxxxxxxxx> wrote: > If tc35815_init_one() fails we must unmap mapped regions. > > Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx> > --- > drivers/net/tc35815.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) No, pcim_xxx APIs are _managed_ interfaces. These resources are released automatically. Actually currently nobody in kernel call pcim_iounmap_regions() now. And _if_ there is any reason to call pcim_iounmap_regions() explicitly, it should be called in tc35815_remove_one() too. So, NAK. --- Atsushi Nemoto -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
