Re: ERROR: do not initialise externals to 0 or NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-07-05 at 22:48 +0200, Dan Carpenter wrote:
> On Mon, Jul 05, 2010 at 10:45:20PM +0200, Dan Carpenter wrote:
> > /* Error variable.  Zero means no error. */
> > int dt3155_errno;
> > 
> > But really this global variable is pretty ugly.  It would be better to
> > eliminate it.  You would have to modify wait_ibsyclr() somehow...
> > 
> 
> The variable gets assigned but never used.  Maybe try figure out if that
> means there is a larger bug, otherwise you can just removed it entirely.
> 
> > regards,
> > dan carpenter

Saw that it never gets used but assigned as looking into it.

Regards,

Joe

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux