On Thu, Jul 01, 2010 at 19:38 +0200, Dan Carpenter wrote: > On Thu, Jul 01, 2010 at 05:16:43PM +0400, Kulikov Vasiliy wrote: > > - Sg_fd *sfp; > > + Sg_fd *sfp = filp->private_data; > ^^^^^^^^^^^^^^^^^^ > Dereferenced here. > > > unsigned long req_sz, len, sa; > > Sg_scatter_hold *rsv_schp; > > int k, length; > > > > - if ((!filp) || (!vma) || (!(sfp = (Sg_fd *) filp->private_data))) > > + if ((!filp) || (!vma) || !(sfp)) > ^^^^^ > > Checked here. Oops, I've loosed it... The problem is that this driver is not even compileable. Patch v2 coming soon) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html