Re: [PATCH 01/25] r852: remove casts from void*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 29, 2010 at 02:14:57PM +0400, Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
> 

1) The subjects are not helpful.  This one should say something about
"mtd" but it doesn't.
2) These haven't been run through checkpatch.pl.  In fact, I can't be 
certain anyone looked at these patches when I see things like:

-    if((( lp = (struct wl_private *)dev->priv ) != NULL ) &&
-          !( lp->flags & WVLAN2_UIL_BUSY )) {
+    if((( lp = dev->priv ) != NULL ) &&
+       !( lp->flags & WVLAN2_UIL_BUSY )) {

On the recieving end, someone has to review every patch that gets merged.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux