On Sun, 20 Jun 2010, Julia Lawall wrote: > From: Julia Lawall <julia@xxxxxxx> > > The path around the loop ends with the lock held, so the call to mutex_lock > is moved before the beginning of the loop. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) [ ... ] > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c > index c940267..850d02a 100644 > --- a/drivers/hid/hid-debug.c > +++ b/drivers/hid/hid-debug.c > @@ -949,8 +949,8 @@ static ssize_t hid_debug_events_read(struct file *file, char __user *buffer, > int ret = 0, len; > DECLARE_WAITQUEUE(wait, current); > > + mutex_lock(&list->read_mutex); > while (ret == 0) { > - mutex_lock(&list->read_mutex); > if (list->head == list->tail) { > add_wait_queue(&list->hdev->debug_wait, &wait); > set_current_state(TASK_INTERRUPTIBLE); Applied, thanks Julia. -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
