Dan Carpenter schrieb: > If oui were a null variable then vic_provinfo_alloc() would leak memory. > But this function is only called from one place and oui is not null so > I removed the check. > > I also moved the memory allocation down a line so it was easier to spot. > (No one ever reads variable declarations). > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > diff --git a/drivers/net/enic/vnic_vic.c b/drivers/net/enic/vnic_vic.c > index d769772..0a35085 100644 > --- a/drivers/net/enic/vnic_vic.c > +++ b/drivers/net/enic/vnic_vic.c > @@ -25,9 +25,10 @@ > > struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, u8 *oui, u8 type) > { > - struct vic_provinfo *vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags); > + struct vic_provinfo *vp; > > - if (!vp || !oui) > + vp = kzalloc(VIC_PROVINFO_MAX_DATA, flags); > + if (!vp) > return NULL; > > memcpy(vp->oui, oui, sizeof(vp->oui)); > -- This looks like memdup() ? re, wh -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html